better downloader handling

README.md

@@ -5,18 +5,15 @@ Want to hear those uwu-voices from japan but don't understand anything that is w
 
 ## Usage
 1. Change your ingame language to whatever you want the *voice* language to be.
-2. Download this repository (from the release tab) and put the contents into a folder.
-3. Right-click the vallc.ps1 file and "Run with PowerShell". A folder should open now. (If it doesn't, please go to `%localappdata%` and create a folder called `ValorantLangChanger`.)
-4. Put the vallc.ps1 file and the ManifestDownloader.exe into that folder.
-5. Open vallc.ps1 in your favorite text editor. Change the top 4 values accordingly and save it.
-6. Copy your Valorant shortcut, then right-click the copy and select Properties.
-7. In the target field, there should be something like this: `"D:\Riot Games\Riot Client\RiotClientServices.exe" --launch-product=valorant --launch-patchline=live`.
-8. Infront of that, put `powershell.exe -ExecutionPolicy Bypass -File "%localappdata%\ValorantLangChanger\vallc.ps1" `. Notice the space at the end.
-9. The full target should now look like this: `powershell.exe -ExecutionPolicy Bypass -File "%localappdata%\ValorantLangChanger\vallc.ps1" "D:\Riot Games\Riot Client\RiotClientServices.exe" --launch-product=valorant --launch-patchline=live`. Press Ok.
-10. You can now use this shortcut to launch Valorant with different languages.
+2. Download the latest vallc.ps1 file from [here](https://github.com/SuspiciousActivity/ValorantLanguageChanger/releases).
+3. Right click and choose "Run with PowerShell".
+4. Follow the setup and have fun!
 
 ## Is this a virus??
-No. If your antivirus has a problem with the exe file, it comes from [here](https://github.com/Morilli/ManifestDownloader). You can download the latest release there if you want. You can view the source of the ps1 script as well.
+No. This file downloads an additional exe file from [here (github.com)](https://github.com/Morilli/ManifestDownloader) which might be flagged as a virus.  
+It is used to download the latest language files from the official Riot Games servers.  
+You can have a look at the script's code and the exe's code as well.  
+If your antivirus has a problem, you could try to exclude the folder `%localappdata%/ValorantLangChanger/` from your antivirus.
 
 ## Thanks to
 https://github.com/Morilli/ManifestDownloader this downloads the latest language files!

vallc.ps1

@@ -33,7 +33,9 @@ try {
 	Write-Host 'Fetching VALORANT config from Riot Games...' -ForegroundColor Green
 	$patchConfigs = (ConvertFrom-Json (Invoke-WebRequest -Uri 'https://clientconfig.rpg.riotgames.com/api/v1/config/public?namespace=keystone.products.valorant.patchlines').Content).'keystone.products.valorant.patchlines.live'.platforms.win.configurations
 } catch {
+	Write-Host 'Error contacting Riot Games servers' -ForegroundColor Red
 	Write-Host $_
+	Read-Host
 	Exit
 }
 
@@ -201,14 +203,21 @@ try {
 
 	if ($patchUrl -ne $lastPatchUrl) {
 		Write-Host 'Downloading new language files...' -ForegroundColor Green
-		$patchUrl | Out-File -FilePath (-join($savePath, 'url.txt'))
-		Start-Process -Wait -NoNewWindow -FilePath (-join($savePath, $manifestDownloaderFile)) -ArgumentList ($patchUrl,'-b','https://valorant.secure.dyn.riotcdn.net/channels/public/bundles','-l',$config.textLang,$config.voiceLang,'-o',$savePath,'-f','.+Text-WindowsClient.+')
-		Write-Host 'Downloaded new language files!' -ForegroundColor Green
+		$downloaderProcess = Start-Process -PassThru -Wait -NoNewWindow -FilePath (-join($savePath, $manifestDownloaderFile)) -ArgumentList ($patchUrl,'-b','https://valorant.secure.dyn.riotcdn.net/channels/public/bundles','-l',$config.textLang,$config.voiceLang,'-o',$savePath,'-f','.+Text-WindowsClient.+')
+		if ($downloaderProcess.ExitCode -eq 0) {
+			$patchUrl | Out-File -FilePath (-join($savePath, 'url.txt'))
+			Write-Host 'Downloaded new language files!' -ForegroundColor Green
+		} else {
+			Write-Host 'Error trying to download new language files!' -ForegroundColor Red
+			Read-Host
+			Exit
+		}
 	} else {
 		Write-Host 'Up to date!' -ForegroundColor Green
 	}
 } catch {
 	Write-Error 'Can not check for new language files' -ForegroundColor Red
+	Read-Host
 	Exit
 }